[BUGFIX] Fix Captcha Validator

Classes/Controller/ActionController.php

@@ -28,6 +28,7 @@ use TYPO3\CMS\Extbase\Service\EnvironmentService;
 use TYPO3\CMS\Extbase\Service\ExtensionService;
 use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
 use Blueways\BwCaptcha\Validation\Validator\CaptchaValidator;
+use TYPO3\CMS\Frontend\Authentication\FrontendUserAuthentication;
 
 class ActionController extends BaseController
 {
@@ -839,23 +840,40 @@ class ActionController extends BaseController
     /** **/
     protected function valideCaptcha($captchaId, $value
     ) {
-        $cacheIdentifier = $GLOBALS['TSFE']->fe_user->getKey('ses', $captchaId);
+        $captchaPhrases = $this->getFeUser()->getKey('ses', 'captchaPhrases');
-
+        if (!$captchaPhrases || !is_array($captchaPhrases) || !is_string($value)) {
-        if (!$cacheIdentifier) {
             $this->addValidationError(
                 'captcha',
                 'validator.notvalid'
             );
         }
         // get captcha secret from cache and compare
-        $cache = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Cache\CacheManager::class)->getCache('bwcaptcha');
+        $time = time();
-        $phrase = $cache->get($cacheIdentifier);
+        $captchaPhrases = array_filter(
-        if ($phrase && $phrase === $value) {
+            $captchaPhrases,
+            function ($captchaLifetime) use ($time) {
+                return $captchaLifetime > $time;
+            },
+            ARRAY_FILTER_USE_KEY
+        );
+        foreach ($captchaPhrases as $lifetime => $captchaPhrase) {
+            $isValid = !empty($captchaPhrase) && $captchaPhrase === $value;
+            if ($isValid) {
+                // remove solved captcha
+                unset($captchaPhrases[$lifetime]);
+                $this->getFeUser()->setKey('ses', 'captchaPhrases', $captchaPhrases);
+                $this->getFeUser()->storeSessionData();
                 return true;
             }
+        }
         $this->addValidationError(
             'captcha',
             'validator.notvalid'
         );
     }
+
+    protected function getFeUser(): FrontendUserAuthentication
+    {
+        return $GLOBALS['TSFE']->fe_user;
+    }
 }

Configuration/TCA/tx_templatesaide_domain_model_dummy.php

@@ -30,17 +30,7 @@ return [
             'exclude' => true,
             'label' => 'LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.language',
             'config' => [
-                'type' => 'select',
+                'type' => 'language',
-                'renderType' => 'selectSingle',
-                'special' => 'languages',
-                'items' => [
-                    [
-                        'LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.allLanguages',
-                        -1,
-                        'flags-multiple'
-                    ]
-                ],
-                'default' => 0,
             ],
         ],
         'l10n_parent' => [

Configuration/TCA/tx_templatesaide_domain_model_translation.php

@@ -30,17 +30,7 @@ return [
             'exclude' => true,
             'label' => 'LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.language',
             'config' => [
-                'type' => 'select',
+                'type' => 'language',
-                'renderType' => 'selectSingle',
-                'special' => 'languages',
-                'items' => [
-                    [
-                        'LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.allLanguages',
-                        -1,
-                        'flags-multiple'
-                    ]
-                ],
-                'default' => 0,
             ],
         ],
         'l10n_parent' => [