Improve debugging, add timing information

Ldap has the potential to slow down compiles if a search takes too long.
Here we add timing information to the debug output, so that in case of
question, we can at least have a method of determining the time a given
search took.
This commit is contained in:
Zach Leslie 2015-06-21 21:57:56 -07:00
parent 403ded3526
commit a3ce58dc85

View File

@ -59,7 +59,6 @@ module PuppetX
} }
end end
Puppet.debug(conf)
return conf return conf
end end
@ -73,8 +72,7 @@ module PuppetX
conf = self.get_config() conf = self.get_config()
Puppet.debug("Searching ldap base #{base} using #{@filter} for #{@attributes}") start_time = Time.now.to_i
ldap = Net::LDAP.new(conf) ldap = Net::LDAP.new(conf)
ldapfilter = Net::LDAP::Filter.construct(@filter) ldapfilter = Net::LDAP::Filter.construct(@filter)
@ -87,9 +85,12 @@ module PuppetX
:time => 10) do |entry| :time => 10) do |entry|
entries << entry entries << entry
end end
Puppet.debug(entries) end_time = Time.now.to_i
Puppet.debug("Searching #{@base} for #{@attributes} using #{@filter} took #{end_time - start_time} seconds")
return entries return entries
rescue rescue Exception => e
Puppet.debug('There was an error searching LDAP #{e.message}')
Puppet.debug('Returning empty array')
return [] return []
end end
end end